search

BCHSI / philter-ucsf

Open source clinical text de-identification
BSD 3-Clause "New" or "Revised" License
107 stars 50 forks source link

Switch file path creation from using string concatenation to using os.path.join #19

Closed tmills closed 1 year ago

tmills commented 1 year ago

If it uses os.path.join instead of '+' to join directories to filenames it is less fussy about what the input arguments look like (whether they have a trailing slash).

tmills commented 1 year ago

I think I found all the places in philter.py but there could be 1) some i missed; 2) some i did incorrectly; and 3) other places in the library to update. would be good to have someone take a look or run better-coverage tests.

tmills commented 1 year ago

just noticed Paul Heider submitted a similar one 2 years ago 😆 sorry!