search

BCJTI / ng2-cookies

Simple library to deal with cookies in Angular2
64 stars 31 forks source link

Publish a new version to npm #63

Open denissb opened 5 years ago

denissb commented 5 years ago

The current version on npm is outdated and causes some problems with the latest build systems (webpack 3+), can we publish a new version with the latest changes?

carcamano commented 5 years ago

Hi Denis.

Can you send me a PR with required changes?

Thanks

denissb commented 5 years ago

Sorry, my bad had incorrect version in package-lock.json. Closing.

denissb commented 5 years ago

No, the porblem is still there when building with @angular/cli, I get: LicenseWebpackPlugin✖ ｢wdm｣: TypeError: licenseType.indexOf is not a function at LicenseTextReader.readLicense (/Users/id844903/proximus/web/magnolia-angular-usage-ng/node_modules/@angular-devkit/build-angular/node_modules/license-webpack-plugin/dist/LicenseTextReader.js:29:40) at PluginChunkReadHandler.processModule (/Users/id844903/proximus/web/magnolia-angular-usage-ng/node_modules/@angular-devkit/build-angular/node_modules/license-webpack-plugin/dist/PluginChunkReadHandler.js:52:62)

There is not code change required for this as I see in package.json the version is specified as a string (is an object in 1.0.12 on npm, which is deprecated). I think you just need to publish a new one with the changes since Apr 26, 2017. I am not the owner of the package so I can't do it :(