BCLab-UNM / SC2

Swarmathon Team Code for the NASA Space Challenge 2 Competition
MIT License
2 stars 0 forks source link

Add Disparity Map and Point Cloud Topics to the Simulation #59

Closed Antonio-Griego closed 4 years ago

Antonio-Griego commented 4 years ago

This pull request adds a launch file that starts a stereo image processing node.

This node is part of a ROS package defined in detail here: http://wiki.ros.org/stereo_image_proc

It generates a disparity map based on the left and right camera data sensors on the robot. It also generates a point cloud using the disparity and the cameras.

Simple use instructions:

Specific Requests for Feedback:

Carter90 commented 4 years ago

Yes adding the changes to have the /scout_1/points2 point cloud to the rviz file would be appreciated

Carter90 commented 4 years ago

The merge into scoots launch was good tested. Looks like we need to do some calibration here is a view of round 2's excavator's bucket bucket2 Bucket

Antonio-Griego commented 4 years ago

I ran the updated launch script and things appear to work:

Screenshot from 2020-07-31 10-17-34

One issue I'm not familiar with is that "Task manager restarted" error. I seem to consistently get it. Is this expected behavior from something or is it a break I need to fix?

Other than that uncertainty it seems like this is good from my end.

Antonio-Griego commented 4 years ago

The merge into scoots launch was good tested. Looks like we need to do some calibration here is a view of round 2's excavator's bucket bucket2 Bucket

Thanks for finding this,

is this calibration something that must be done before the pull request is complete? or is this a separate issue?

Carter90 commented 4 years ago

The task restated is just that if you ran the task node before during the same simulation it will restart the state machine where it left off. So it's expected, the reason it's an "error" is if task crashes and gets restarted we want to know about it but now when we kill it.

Carter90 commented 4 years ago

We can calibrate later, I'm happy to have data even if I mentally have to set an offset