gmfricke
commented
4 years ago Thanks Carter!
From: Carter Frost notifications@github.com Reply to: BCLab-UNM/SC2 reply@reply.github.com Date: Sunday, August 9, 2020 at 3:08 AM To: BCLab-UNM/SC2 SC2@noreply.github.com Cc: Matthew Fricke matthew@fricke.co.uk, Review requested review_requested@noreply.github.com Subject: [BCLab-UNM/SC2] Autonomous/manual mode && MinCore->Core rename (#76)
The general launch file can now be called with a mode augment anything that is not "auto" will place the rover in a manual mode so you can then call the repl or specific behaviors for testing. This will eliminate the need to comment out the task launch in core to do testing.
roslaunch ./launch/scoot.launch "search:=searchRandomWalk" "mode:=manual" ROS_NAMESPACE="/scout_1" rosrun scoot repl.py
You can view, comment on, or merge this pull request online at:
https://github.com/BCLab-UNM/SC2/pull/76
Commit Summary
- Driver.py: removed all brake related code but release,created brakes_off
- scoot/src/behaviors/scout/searchRandomWalk.py: brake when done moving
- launch/scoot.launch & src/scoot/launch/scoot.xml: added round arg
- src/scoot/src/Task.py: changed rosparam round_num to round
- launch/qualround[1-3].launch: initial creation
- src/scoot/src/Core.py: name refactor MinCore->Core, added mode argument
- launch/*.launch: added mode arg for autonomous & manual
- src/scoot/launch/scoot.xml: added mode arg and pass it to core
- src/scoot/launch/scoot.xml: change mode to general rosparam
File Changes
- A launch/qual_round_1.launchhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-0e382cb90d3725fb3b41f56eee81e0a3 (9)
- A launch/qual_round_2.launchhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-83ec1aef439e1a63999de398d3c7ceb2 (19)
- A launch/qual_round_3.launchhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-ba6da5d4542dfe9dc089eca7b67da450 (8)
- M launch/scoot.launchhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-616e9470ec7d46c8ed472256e0b06c41 (5)
- M src/scoot/launch/scoot.xmlhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-0d6ff2ca292cd0eabe76ee4c5bf31b83 (6)
- A src/scoot/src/Core.pyhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-6efd674e90d34f9ab1cde6d6876f244e (28)
- M src/scoot/src/Driver.pyhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-0df70377e1c329ded2e04337485b39cf (36)
- D src/scoot/src/MinCore.pyhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-04b877e9dc55102e810da9d13553fd30 (22)
- M src/scoot/src/Task.pyhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-226d9b048be437daa44bc3f07e417c5a (2)
- M src/scoot/src/behaviors/scout/searchRandomWalk.pyhttps://github.com/BCLab-UNM/SC2/pull/76/files#diff-226109a643c35e27bd42e052137e5d12 (2)
Patch Links:
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/BCLab-UNM/SC2/pull/76, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6DSEZ3QHZHHSNUXSSEJODR7ZRR7ANCNFSM4PZC4Y3A.
The general launch file can now be called with a mode augment anything that is not "auto" will place the rover in a manual mode so you can then call the repl or specific behaviors for testing. This will eliminate the need to comment out the task launch in core to do testing.
roslaunch ./launch/scoot.launch "search:=searchRandomWalk" "mode:=manual"ROS_NAMESPACE="/scout_1" rosrun scoot repl.py