search

BCLibraries / primo-services

MIT License
9 stars 4 forks source link

Add `resourcetype_facet` and `frbr_group_id` to `Bibrecord` #14

Closed danmichaelo closed 8 years ago

danmichaelo commented 8 years ago

Even though frbr_group_id is mentioned in the README, it seems like it wasn't implemented yet.

I haven't been able to find any documentation on the frbrtype, have you? So far, I have only seen frbrtype=5 for combined ("frbrized") records, and frbrtype=6 for single records. Afaics there is no need for the frbr_group_id for single records. (I have no idea what frbrtype 1, 2, 3 and 4 might mean if they exists)

There is a similar way of handling it in https://github.com/scotdalton/exlibris-primo/blob/master/lib/exlibris/primo/pnx/frbr.rb , so I'm quite confident it's not totally off.

Otterfan commented 8 years ago

Who could ever understand the reverse scale of FRBRization? frbrtype=1 must be awfully FRBRized...

danmichaelo commented 8 years ago

Good one :D