search

BCLibraries / primo-services

MIT License
9 stars 4 forks source link

Replace Guzzle dependency with HTTPlug #19

Closed danmichaelo closed 5 years ago

danmichaelo commented 7 years ago

Allows people to use Guzzle 5 or 6 or something else. Note that this will break for users of the AlmaClient class, since the constructor has been changed from

public function __construct(\Guzzle\Http\Client $client ...

to

public function __construct(\Http\Client\HttpClient $client ...

Since it will break anyways, perhaps we should also move the $client parameter after $alma_host and $library to make it optional to specify?

In the third commit, I added support for specifying protocol as part of the hostname (since our Primo instance now only accepts https connections), but in a backwards compatible manner.

danmichaelo commented 6 years ago

@Otterfan , do you have a chance to look at this?

danmichaelo commented 5 years ago

I'm updating and re-creating this one.