Changed language on manage volunteers button and modal to be more descriptive

[bledsoef]

Issue

Fixes issue #1123

The language on the button and the modal of the Manage Volunteers page to add users to an event was poor. We went through and made it consistent and make more sense from a first-timer's perspective.

Changes

• Made the text that the Add Volunteers button on the Manage Volunteers page respond to whether the event is past, the rsvp list is full, or rsvp is required.
• Changed the wording on all the buttons and modal titles to ensure that our language was consistent.
• Did a teeny refactor to improve code reusability.

Testing

• switch to 1123_fix_volunteer_modal_language\
• source setup.sh and ./database/reset_database.sh test
• Create a past event and navigate to the manage volunteers page.
• Make sure that the button says Add Volunteers, and that the modal has the same language.
• Make the event a future event and set the rsvp limit to 1.
• Navigate back to the manage volunteers page.
• Make sure that the button says RSVP Volunteers, and that the modal has the same language.
• Add a user like Sreynit to the RSVP list, now the limit should be hit and the waitlist should be active.
• Make sure that the button says Waitlist Volunteers, and that the modal has the same language.
• Finally, check that if you add multiple volunteers at the same time through the modal the Add/RSVP/Waitlist button turns plural.

[andersoncedu]

I added people and checked and unchecked all checkboxes.

[stevensonmichel]

When I added the same person as RSVP and Waitlist, the flash message says "... is already in table". A more descriptive message would be welcome.

[stevensonmichel]

The plural form is quite broken.

[stevensonmichel]

Also, when I delete a volunteer who Rsvp'd, the button is still Waitlist Volunteers, especially if I still have people on the waitlist. From a functional perspective, I believe it would be better to have the button changed to its previous state. That might be for another issue though.

[stevensonmichel]

For unknown reasons, when I have multiple people on the waitlist and I click on View, that line ____"{% set buttonName = "Join Waitlist" if (eventData.rsvpLimit is not none) and (currentEventRsvpAmount[eventData.id] >= eventData.rsvpLimit) else "RSVP" %}_ " __from eventView.html is breaking the code.

[bledsoef]

Change the language on the Add Volunteer Modal when the event is upcoming

[github-actions[bot]]

View Code Coverage