BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Updated sidebar display to show unapproved courses and interested students #1154

Closed bledsoef closed 3 months ago

bledsoef commented 4 months ago

Issue

Fixes issue #1146 and issue #1147

We were wanting to the admin to be able to see important information like courses they need to approve and students who expressed interest since those require their action.

Changes

Testing

andersoncedu commented 3 months ago

Should the admin tab also show 'Admin (5)' ? This would let the admin know that there are items that need addressed in the admin tab.

andersoncedu commented 3 months ago

Additionally, I think it might be more noticeable if there was a color change when there was something requested or a box or something. Otherwise, the issue looks good.

andersoncedu commented 3 months ago

Without context, the numbers don't look like things that need to be addressed; they just look like numbers randomly on the page, in my opinion.

bledsoef commented 3 months ago

@andersoncedu In response to your comments, I should have commented this here but Brian and Anderson's suggestion was a hover to show more detail about the numbers. Otherwise since there are only a handful of admins and this will be demoed for them having it explicitly stated what the numbers are isn't super important.

bledsoef commented 3 months ago

Let Admin see the amount of unapproved courses they have in the sidebar

bledsoef commented 3 months ago

Display the amount of interested minor students in the sidebar

github-actions[bot] commented 3 months ago

View Code Coverage

gahimbaref commented 3 months ago

Additionally, I think it might be more noticeable if there was a color change when there was something requested or a box or something. Otherwise, the issue looks good.

I think a color might not be necessary. Having the numbers there seems to be sufficient