BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Remove the ability for an event participant to have None hours earned #1162

Open bledsoef opened 3 months ago

bledsoef commented 3 months ago

Low priority issue, leave for summer cohort

The EventParticipant model having a nullable hoursEarned field is old functionality leftover from when EventParticipant and EventRsvp were the same table. There really shouldn't be a case when their hours earned is None, at the very least it should only be 0. We need to change the following:

bledsoef commented 3 months ago

Remove the ability for an event participant to have None hours earned

seedyjahateh commented 3 weeks ago

@Ndiayem14 and I are working on this issue

Ndiayem14 commented 3 weeks ago

We are working on this problem to see how to fix it.

Ndiayem14 commented 3 weeks ago

@bledsoef HoursEarned is None if a participant volunteers in a 'no-hours-earning' event (e.g. empty bowls), and a number in an 'hours-earning-event (e.g. tutoring).

We don't think there's an issue. What do you think?