search

BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Changed faculty and course labels and made the course name to also show the course number #1214

Closed MImran2002 closed 4 months ago

MImran2002 commented 5 months ago

The changes we made is that we created a file in models that would produce an attribute for course name and number. We also created a test for the function and tested it when both course name and number exist, when none exit and when either one of them exist. We also went to html page for slcmanagement.html and added some jinja codes. We also have to add import statements across the pages.

Fixes #1206 and #1164

vungc commented 5 months ago

Modifications:

  1. Added “name” and “abbr” back into the dictionary in logic/serviceLearningCourses.py and changed the combination of name and abbreviation as “displayName”

  2. “namenumcombo” function changed to “displayName” and moved to logic

  3. changed slcMangement.html to use displayName from the courseDict

  4. added tests to test the displayName from the logic files displayName and serviceLearningCourses

BrianRamsay commented 5 months ago

@MImran2002 , is this an old PR? There are unresolved comments, still.

WackyWeaver commented 5 months ago

I would approve this. I ran the unit tests and checked for where there was change. It was looking great as far as I could see 👍

github-actions[bot] commented 4 months ago

View Code Coverage