BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Enhanced 'import_users.py' script using logging module #1240

Open ali-ramazani opened 1 week ago

ali-ramazani commented 1 week ago

We enhanced the import_users.py script by integrating Python's logging module to provide detailed and descriptive log messages. These improvements will make the cron.log file significantly more informative, aiding in monitoring the script's execution and diagnosing any issues that arise from crontab scheduled tasks.

github-actions[bot] commented 1 week ago

View Code Coverage

Ndiayem14 commented 1 week ago

We have upgraded the import_users.py script by incorporating Python's logging module to generate comprehensive and detailed log messages. This enhancement will make the cron.log file much more insightful, facilitating better monitoring of the script's performance and easier troubleshooting of any issues that emerge from the crontab-scheduled tasks.

CollegeStevenLN commented 11 hours ago

This PR seemed to be pretty straightforward. I saw obvious problems with the logging, and I ran unit testing for this. This was not client side, so I saw no need to try to break it on that end. I would approve this PR.