fixed action issue in course review - Githubissues

BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

fixed action issue in course review #1245

Closed ali-ramazani closed 2 days ago

ali-ramazani commented 1 week ago

Fixed the issue with the action button malfunctioning in the course proposal page

Issue Ticket Number: 1244

Issue

[ ] The reviewProposal.html could not access the variables and functions in the JS file because the JS was a module
[ ] Functions and variables were locally scoped to the module
[ ] The JavaScript file included a few lines of code that manually set some functions to the window object to make them globally accessible

Changes

[ ] I defined an allExports object to localize all the functions for easier addition/removal
[ ] A for loop is used to attach all functions on the window object

Ndiayem14 commented 1 week ago

We fixed the issue in the course review proposal, which needed to be fixed on approved/unapproved.

github-actions[bot] commented 6 days ago

View Code Coverage

ali-ramazani commented 2 days ago

We moved this issue to a new pull request