BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Import courses #1252

Open Araxision opened 5 days ago

Araxision commented 5 days ago

We changed the functionality of importing courses. When a course is imported, it checks if it already exists in the courses table. If it does exist then it copies the all information other that status(originally it was just directly set to 4, so we did not change it) and term (because term might be different). It does not check if the course exists in the same term anymore. On discussion with Karina, she pointed out that we should not completely rule out on the basis on term as there might be multiple sections of a class with the same course name and term. Maybe we can add another enhancement where it checks for the section but I don't think we are able to import sections through the spreadsheet. Have not tried to import it yet.

Issue : #1180

New Updates On discussion with Brian, we decided that we are going to ignore the case of sections for now and not add any courses that have the same course abbreviation or term. We checked for three conditions. If the Course Abbreviation and Term is the same, we add the course participants. If the Course Abbreviation is the same and the term is different there are two sub-conditions. If the term is older than that of the most recent Course Abbreviation match, a new course is added without copying any information. If the term is newer than that of the most recent Course Abbreviation match, a new course is added but with information copied from the match. If none of the Course Abbreviation or term match, we enter a new course into the table.

github-actions[bot] commented 1 day ago

View Code Coverage

CollegeStevenLN commented 1 day ago

Reviewing this PR with Seedy

seedyjahateh commented 1 day ago

Made code review and used unintended inputs yet it still works just fine. I recommend commenting/documenting code though.