BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

fixed renew button issue in course proposal page #1258

Closed ali-ramazani closed 3 months ago

ali-ramazani commented 5 months ago

Issue Number: 1257 | Issue Link: 1257

The renew button had an issue and the renew function wasn't catching the value sent from the UI. The problem was the ajax call wasn't being made and the function wasn't returning anything. We fixed it by adding $('#renewBtn').on('click', renew); to the .ready() function at the top to capture ajax call.

MImran2002 commented 5 months ago

Ali, the View side is perfect so does the JavaScript file just need some clean up I feel like comments on line 45 and 48 can be deleted as they are repeating what the code below does when the codes after the comment are easy to understand.

github-actions[bot] commented 3 months ago

View Code Coverage

bledsoef commented 3 months ago

Already fixed this and the additional renew onclick you added is unnecessary, thank you though!