search

BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

View Past Event Toggle #1270

Closed vungc closed 3 months ago

vungc commented 4 months ago

“View past event” toggle in the events list page untoggles when the term is changed. The toggle needs to be updated to stay toggled even when the term is changed. It also cannot be toggled at all for Fall 2020 and Spring 2021 (pictured below)

image image

Mbeweg commented 4 months ago

The “View past event” toggle

vungc commented 4 months ago

So we saw this code on the event_list.html var g_isPastTerm ={{"false" if selectedTerm.isFutureTerm or selectedTerm.isCurrentTerm else "true" }}; and figured out that the disabling of the toggle for the terms Fall 2020 and Spring 2021 were because they are past terms. We did not realize that the current term in the system was Summer 2021. We are leaving that alone since it is not an issue. We will now be focusing on making the toggle consistent throughout the current and future terms.

bledsoef commented 3 months ago

Closed in PR #1290