BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Timepicker issue #1288

Closed ali-ramazani closed 2 weeks ago

ali-ramazani commented 4 months ago

Fixes issue #1267

We fixed the issue with the start time and end time buttons not triggering the timepicker dropdown attached to the input field. The issue was the timepicker method in the timepicker object didn't expect "show" as argument. Instead, it expected "open". Moreover, we prevent the event handler from propagating up because it would close the dropdown as in the implementation of the timepicker closes the dropdown if it's not trigged from the input field directly.

thealphagurlux commented 4 months ago

To add on to Ali's comment, we also implemented an if else statement into the function bound to the button because the button would open the time picker scroll but clicking it again would not close the scroll box, so we used the time pickers 'closed' method in order to check if the scroll box was open or not, and close and open it appropriately.

JohnCox2211 commented 4 months ago

Corrected things mentioned in comments

github-actions[bot] commented 2 months ago

View Code Coverage

bledsoef commented 2 weeks ago

There are some awful merge conflicts. Going to close this and reimplement the changes in development.