Fixed unapprove and approve functionality on review modal - Githubissues

BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College

BSD 3-Clause "New" or "Revised" License

1 stars 8 forks source link

Fixed unapprove and approve functionality on review modal #1316

Closed bledsoef closed 2 months ago

bledsoef commented 2 months ago

Issue

Fixes issue #1244

For some reason the unapproveProposal and approveProposal functions were no longer accessible in the reviewModal.html template.

Changes

I removed the unapproveProposal and approveProposal onClick handlers from the template to the javascript to ensure they can properly reference the functions.
Only add the onClick handlers to the modal when the request to populate the modal appears so that there is an actual button to add it to.

Testing

Checkout fix_unapprove_1244
Reset database
Go to Course Management and review a proposal
Verify that you can both approve and unapprove proposals.

github-actions[bot] commented 2 months ago

View Code Coverage