BCStudentSoftwareDevTeam / celts

Web app to support the CELTS program at Berea College
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

Validate for Duplicate Event Entries within Multiple Offering Modal #1327

Closed hoerstl closed 2 months ago

hoerstl commented 2 months ago

Issue Description

There is no form validation preventing a user from creating multiple of the same event using the multiple offerings modal. Currently, when they try, the form submits and returns a warning that the "event already exists" because it is a duplicate event. This is not intended behavior and the user should be warned beforehand.

Fixes issue #1306

Changes

Dev Note: After careful consideration, we determined that we should prevent a user from creating two offerings of an event if they had the same name, date, start time, even when they have different end times. We cannot think of a situation when two events wouldn't be the same even with different end times.

Testing

First, prepare your local development environment and run the application Preparation:

Now, you should create an event under any program and click the slider to give the event multiple offerings.

image

In the modal, do your best to create duplicate events and save the event page. If you cannot create multiple offerings so that when you save the event, you get a warning message saying that the "event already exists", then our PR is working. Try creating two events that have the same fields but differ once in each of the following areas per test: All fields same except event name All fields same except event date All fields same except start time

e.x.

image
hoerstl commented 2 months ago

Validate Event Name Entries for Multiple Offering Modal #1306

hoerstl commented 2 months ago

Error saving single events when start date is not specified

hoerstl commented 2 months ago

Error saving single events when start date is not specified

hoerstl commented 2 months ago

We have made all the suggested changes and we're ready for a re-review of our PR

github-actions[bot] commented 2 months ago

View Code Coverage