Multiple Offerings and Recurring Events Refactor

[ojmakinde]

Issue Description

Fixes #1335

• Most of the existing logic for our multiple offerings and recurring events are duplicates. We need to merge both functionalities into one, and change the workflow on the frontend.

Changes

• Added a new integer column, seriesId, into the model.
• Refactored logic that used MultipleOffering and RecurringId to use the seriesId, merging logic where necessary.
• Reworked the UI on Create Event to accomodate the change, using a single toggle for both multiple offerings and recurring series, instead of our previous two toggles for multiple offerings and recurring events.
• Updated tests.

Testing

• Run the test suite and ensure it is functional.
• Step through parts of the application and ensure that they are functional despite the many introduced changes.

[thealphagurlux]

The UI for the recurring events looks a little bit awkward when you first click on it and the style of the button is not consistent with the UI with the rest of the site.

I suggest changing the text of the button to something like "add another offering" and have the pop-up look populate like this by default

One last thing the button only appears in the center of the window, but you can click the highlighted area and it still activates its function.

[Karina-Agliullova]

There is an issue with the toggle for multiple offerings, specifically, with the weekly option. If on the multiple offerings modal, we select weekly toggle, then we cancel it so that modal closes, then we reopen the modal for multiple offerings, and click on the weekly toggle, it shows the unconstructed table with Generated Events, but it is empty because I did not yet create any event, so it seems awkward to have a table with column names but no information. The table shouldn't be generated at all if only I did not already create the weekly event with the information.

[Karina-Agliullova]

Another issue with the weekly toggle for multiple offerings is that it saves all the information that I add to it. So if I create an event with a weekly toggle, and then I cancel it, and then reopen the modal, it will still show the modal with all the information I input previously, which shouldn't be the case unless we save it

[Karina-Agliullova]

When I open the modal, and I do not input any information, and hit Save, it executes successfully even though it shouldn't. It creates an empty table with no information, just the column names. And that is the same way if I click on the toggle for weekly events in the modal, and I don't input any information, and hit Save, it says that Events created, even though it is empty

[Karina-Agliullova]

Another problem is with the error message in the modal. If I open the modal, and I click on the add button to add events, and I do not input any information, and hit Save, it highlights everything in red, which is good, and leaves an error flash warning message. That is good. But when I cancel the modal and reopen it, there is a warning message left still even though it is not applicable to the new modal opening.

[Karina-Agliullova]

Also, the spacing for the weekly option in multiple offerings seems too tight. It would be nice to give it some space between the boxes and texts

[thealphagurlux]

When making a event occur more than once the name input into the pop-up window will be what the event is displayed as in the event list

When saving the recurring event the event name on the create event page should probably reflect whatever changes are made in the pop-up window

[Karina-Agliullova]

When I create an event, and I add multiple time offering, but I don't input all the info, like I only input Event name, but no dates for multiple offerings, and it still saves it even though it displays the empty table, and I add all the other info outside of modal, like place and description, and then save an event, it throws an error

[Karina-Agliullova]

Something is going on with the datepicker in the modal. I selected the date for today but the time is later than what it is right now, and it is throwing me a warning, saying that I picked the date in the past

[ojmakinde]

Something is going on with the datepicker in the modal. I selected the date for today but the time is later than what it is right now, and it is throwing me a warning, saying that I picked the date in the past

I just tested this in development and the issue exists in development as well. Will fix in this PR though. Thanks for catching that.

[github-actions[bot]]

View Code Coverage