BCStudentSoftwareDevTeam / lsf

0 stars 0 forks source link

Sidebar height does not change with the page content #162

Closed bryantal closed 4 years ago

bryantal commented 4 years ago

Original report by Lisandro Padron (Bitbucket: [Lisandro Padron](https://bitbucket.org/Lisandro Padron), GitHub: escalerapadronl).


How to get there:

This is the sidebar that is on the left of every page of the app.

Files:

To Do:

Currently, whenever more content shows up on the page, such as opening one of the academic years in accordion on the Term Management, there is a gap between the sidebar and the footer. The sidebar should dynamically change its height according to how much content is on the page so that there is no gap in between the bottom of the sidebar and the footer.

bryantal commented 4 years ago

Original comment by William Romano (Bitbucket: [Will Romano](https://bitbucket.org/Will Romano), ).


During the process of resolving this issue, we decided that it might be more effective to create a fixed sidebar. The current iteration of that design involves a sidebar that is left of all other content (with style changes that match the new layout).

bryantal commented 4 years ago

Original comment by William Romano (Bitbucket: [Will Romano](https://bitbucket.org/Will Romano), ).


Made the sidebar accordion open automatically if the user is on a page contained in that dropdown.

bryantal commented 4 years ago

Original comment by William Romano (Bitbucket: [Will Romano](https://bitbucket.org/Will Romano), ).


Successfully merged.

bryantal commented 4 years ago

Original comment by William Romano (Bitbucket: [Will Romano](https://bitbucket.org/Will Romano), ).


Merged with development with changes successfully committed.