search

BCStudentSoftwareDevTeam / lsf

0 stars 0 forks source link

Job Type shows up for Break Terms #171

Closed bryantal closed 4 years ago

bryantal commented 4 years ago

Original report by Lisandro Padron (Bitbucket: [Lisandro Padron](https://bitbucket.org/Lisandro Padron), GitHub: escalerapadronl).

How to get there:

This is in the New Labor Status Form interface.

Files:

To Do:

When a new break LSF is being made, the Job Type of the form is automatically set to Secondary so you should not be able to choose whether it is a Primary or Secondary. However, if you select a non-break term and then select a break term, the Job Type select picker does not go away for the break term. It should be hidden whenever you select a break term, even if is selected after a non-break term was previously selected.

bryantal commented 4 years ago

Original comment by Hila Manalai (Bitbucket: [Hila Manalai](https://bitbucket.org/Hila Manalai), ).

PR is in. Waiting to be merged.

bryantal commented 4 years ago

Original comment by Hila Manalai (Bitbucket: [Hila Manalai](https://bitbucket.org/Hila Manalai), ).

Merged in this PR: https://bitbucket.org/laborstudents/lsf-flask/pull-requests/131