search

BCStudentSoftwareDevTeam / lsf

0 stars 0 forks source link

Modal for more than one LSF in a Break Term not showing up. #184

Closed bryantal closed 4 years ago

bryantal commented 4 years ago

Original report by Lisandro Padron (Bitbucket: [Lisandro Padron](https://bitbucket.org/Lisandro Padron), GitHub: escalerapadronl).

How to get there:

This is on the New Labor Status Form page.

Files:

To Do:

When a supervisor tries to create a new labor status form for a student in a term where that student already has one LSF, a modal show pop up on the screen letting them know that the student is already working with another supervisor. However, this is not happening due to a dictionary, that gets returned from an AJAX call under the isOneLaborStatusForm() in laborStatusForm.js, not having the right information. The dictionary needs to passed the right information from the controller and the controller functions checkForPrimaryPosition() and checkForSecondLSFBreak() should probably be condensed into one function since they are almost identical.

‌

bryantal commented 4 years ago

Original comment by Hila Manalai (Bitbucket: [Hila Manalai](https://bitbucket.org/Hila Manalai), ).

PR is in. Waiting to be merged.
PR URL: https://bitbucket.org/laborstudents/lsf-flask/pull-requests/175

bryantal commented 4 years ago

Original comment by Hila Manalai (Bitbucket: [Hila Manalai](https://bitbucket.org/Hila Manalai), ).

PR is merged.