Closed bryantal closed 4 years ago
bryantal
commented
4 years ago Original comment by Scott Heggen (Bitbucket: sheggen, GitHub: sheggen).
Another issue with this interface (so adding to this issue): Anyone can type in https://lsf.berea.edu/studentOverloadApp/148 and get to an overload application for any student. The controller should check for the correct user and 403 if it’s not the same as the user of the application.
bryantal
commented
4 years ago Original comment by Guillermo Cruz (Bitbucket: cruzg, GitHub: GuillermoCruz32).
A student will need to log in to the system in order to see this application, correct? I just wanted to make sure the currentUse check wouldn’t cause problems, and I can make the change accordingly for the students
bryantal
commented
4 years ago bryantal
commented
4 years ago Original comment by Guillermo Cruz (Bitbucket: cruzg, GitHub: GuillermoCruz32).
The controller has been updated and tested, now the current user cannot access the application unless they are the student who the form is intended for.
bryantal
commented
4 years ago Original comment by Guillermo Cruz (Bitbucket: cruzg, GitHub: GuillermoCruz32).
This issue has been resolved with pull request #192
Original report by Lisandro Padron (Bitbucket: [Lisandro Padron](https://bitbucket.org/Lisandro Padron), GitHub: escalerapadronl).
How To Get There:
Make sure you have a Labor Overload Form for a student in your database. From the Supervisor Portal URL, add this to the end of the URL:
/studentOverloadApp/<formID>. Be sure to replace<formID>with the actual formID of the Overload Form you are referring to.Files:
app/controllers/main_routes/studentOverloadApp.py
app/static/js/studentOverloadApp.js
app/templates/main/studentOverloadApp.html
app/templates/snips/studentOverloadSubmit.html
Tasks:
When a student fills out and submits an Overload Form Application, their reason should be stored in the studentOverloadReason column for an Overload Form in the overloadform table of the database. An email should also be sent out to the student and to the Labor Office letting them know the student has filled their application. Lastly, after pressing submit, the page redirects to the Berea College website home page (http://berea.edu). The only thing that is currently working is the redirection the home page after the Submit button has been clicked. Everything else currently isn’t working and this is due to the page redirection being in the HTML so it happens before the JS and the Python functions can be called.
Notes:
The only way for the Submit button to show up is to click outside the text box after something has been typed, but the only way to write in the textbox is by making sure all the checkboxes at the top of the page are clicked. There should probably be a clearer way of letting the student know that certain things need to be done before they can access a certain part of the page.