BCcampus / bcc-sage

BCcampus theme for marketing site
MIT License
2 stars 1 forks source link

Change title on Call for Proposals page #399

Open ehbeattie opened 4 years ago

ehbeattie commented 4 years ago

Hi,

It's currently called "Calls to Proposals" and should be "Calls for Proposals"

https://bccampus.ca/grants-calls-for-proposals/

Screen Shot 2019-10-16 at 12 41 53 PM
ehbeattie commented 4 years ago

I also can't remember how to get a page to land in the listing.

https://bccampus.ca/grants-calls-for-proposals/2020-festival-of-learning-disruption-transformation-in-higher-education/

dshaykewich commented 4 years ago

Would love for @alex-418 to take me on a tour of the code. To my uneducated eyes, it looks like this heading lives in here: https://github.com/BCcampus/bcc-sage/blob/dev/resources/views/partials/children-open-calls.blade.php But the heading in that file in Github does say "Open Calls for Proposals", so I'm dumbfounded.

dshaykewich commented 4 years ago

@ehbeattie - IIRC,

ehbeattie commented 4 years ago

Hi,

I'm still struggling with this.

I've set one up as an event, and it shows in the events calendar with the "call for proposals" category, but it does not show up on the grants landing page grid nor on the sidebar menu like the one below: https://bccampus.ca/event/call-for-proposals-open-educational-resource-development-for-the-trades/

I've set this one up as a page, with the parent/child relationship so it shows on the righthand sidebar menu, but not in the landing page grid: https://bccampus.ca/grants-calls-for-proposals/2020-festival-of-learning-disruption-transformation-in-higher-education/

Halp! :)

Cheers,

Erin

alex-418 commented 4 years ago

Hi @ehbeattie I'd be glad to help with this.

Please confirm we're reverting https://github.com/BCcampus/bcc-sage/issues/372

As for the Grants landing page, I've found the culprit: Yes, all child pages of the "Grants and Calls for Proposals" should be automatically added in the "Grants currently offered" grid and sidebar as you expected. (Events are not used by our theme here).

The reason 2020 Festival of learning wasn't showing up, is because it had the custom "status" field set to "closed". I've removed this and it is now working as expected. These status fields are reserved for use with Calls for/to proposals, and not grants. If it's set to open, it will show it on the landing page, otherwise in the archive.

closed

Hope that clears things up! Please let me know if you have any further questions.

ehbeattie commented 4 years ago

What the... yes, please. Why on Earth would I have requested that??

Cheers,

Erin