"Plan to attend" button should always be present

[paulagaube]

Description

Not sure if this is a bug or not. Wanted to capture what I saw.

On an Event page, the words "N/A leave blank" appear where the "Plan to Attend" button should be, just below the "Categories" and above "Target Audience".

Expected behaviour

Show the Plan to Attend button so I can add this to myEYPD as a Learner or Organizer.

Steps to reproduce the problem

I noticed this on an event I had originally created some time ago. This event spanned multiple days, and the first days of the event was in the past.

I duplicated the old event and updated the dates to the future. E.g., the button does not appear on this page: https://eypd.bccampus.ca/events/bugs-and-insects-part-4/

I created a couple NEW events with mostly the same information and the Plan to Attend button appeared: https://eypd.bccampus.ca/events/diet-and-nutrition-level-1-2/ https://eypd.bccampus.ca/events/diet-and-nutrition-level-2/

This is what I see while logged in as a Learner:

[alex-418]

@paulagaube This is probably a symptom of brining this change in after this event was created. The "Plan to Attend" button is a feature of the Events Manager plugin that was disabled before.

[mandily-p]

Notes from sprint planning: Will try to change the button behaviour to stay active until the end time of the event instead of the start. If that doesn't work, we'll change the messaging to the user.

[mandily-p]

@kathreenriel Can you let us know what you would prefer here?

1. Persistent button all of the time (my preference)

   • Change the button text to read, "Save to myEYPD".
   • The user can add the event to their myEYPD page at any time/date.

2. Button is displayed until the event end time is in the past

   • After that, a message is displayed, "This event has already taken place. You cannot add it to your events."
   • The user can only add the event o their myEYPD page until the end time of the event.

[mandily-p]

Chatted with Kathreen and we decided allowing users to save events at all times is the best way foward (#1)

She'd also like to add cautioning users with a modal confirmation if the event has already finished, "This event has happened in the past, are you sure you want to add to your events" options include "cancel" and "save event".

[kathreenriel]

@mandily-p My understanding is as you have described and we discussed changing the title of the button from "Plan To Attend" to "Save to myEYPD"

[brettjforsyth]

@kathreenriel @mandily-p This page has a few default options that I would need to override to make this button show up all the time.

• Bookings not enable
• Available spaces 0
• event has started (which brings up the N/A message

Which of those needs to stay and what needs to go?

[kathreenriel]

Stay: Bookings not enable

Available spaces and event has started...I"m not sure the effects of leaving those out or in.

[brettjforsyth]

The button will not be shown when its full booked event started is what is causing the N/A leave blank currently which is actually just a settable label

[brettjforsyth]

@kathreenriel @mandily-p I have reworked this page so that the button shows after an event starts and shows the modal popup. Let me know if there are any visual changes needed before I submit the pull.

[kathreenriel]

@brettjforsyth yes, this looks good

[brettjforsyth]

Perfect. Now just waiting on Brad for a coding question.

[mandily-p]

Just curious - Did you ever find modals elsewhere on the site? I just had the thought that I'm not sure which pattern the site uses - Cancel first or second.

[paulagaube]

@brettjforsyth @kathreenriel FYI, I just created a new event as an Organizer on CERT and inadvertently entered a date for the event that was in the past (January 2018). Since I couldn't see the event anymore as the Organizer (I can't see past events that I haven't planned to attend), I went in as an Administrator and changed the event's dates to 2019, as I had originally intended. Here is the event:

Event Name: Sand, Surf and Kelp: Understanding Ocean Tides Event ID: 1779 Event PostID: 4466

Then I went back to my Organizer account and saw the Event on my myEYPD page, but when went to the event details page, and want to click the "Plan to Attend" button, instead I see "N/A leave Blank".

Since the event is now in the future, I believe the "Plan to Attend" button should still appear?

[bdolor]

re-opening automated closure resolved via https://github.com/BCcampus/eypd/pull/599

[kathreenriel]

Tested this issue and found the following items to be corrected:

1. When a registered user (Organizer or Learner) opens an Event Description page and clicks on SavetomyEYPD a message appears that says, "Please Wait While The Booking Is Being Submitted" the message never disappears until the user clicks on "Save"

2. @paulagaube I couldn't replicate your problem but if an Organizer creates an event that happens in the past and then an Administrator corrects that date the event now has this message associated with it (see below) eventhough the date has been modified by the Admin so that it happens in the future.

3. I was on occasion seeing this style of button when I first started testing this issue about an hour ago. But it doesn't seem to be happening now. @paulagaube do you see this style of button after you clear your cache?

[brettjforsyth]

@kathreenriel 1) This seems to be functionality that has always been there. It is a JS alert message. We can remove it all together but not close it automatically. 2) Is this an issue or just needed clarity? 3) I am not sure what the issue is here? different style than expected?

[kathreenriel]

@brettjforsyth

1. Re: bookings I looked through the bookings settings to disable the message but couldn't see the option to remove it. Yes, I think the message should be removed.
2. Re past dates and edits: I think this needs to be fixed. @paulagaube would like Organizers to see past events eventually so if an Organizer edits an event that includes a past date to a future date this message will appear.
3. Re button style: The button style should be as it appears below (except with text SavetomyEYPD) and change when the cursor hovers over or clicks on the button.

[brettjforsyth]

@kathreenriel can you check in the bookings/Registration section what the "Booking cut-off date" is set to for your events. Based on my testing this is likely the old date and once changed will make the modal confirmation go away.

[brettjforsyth]

@kathreenriel 1) I have created a new ticket to address this 2) I believe will be resolved with my above comment and is not a coding related issues. 3) @mandily-p create #597 which I think is the best place to capture all the work related to buttons

[kathreenriel]

Validated this issue in its original form at the top : N/A leave blank in place of "Place To Attend" appears when events that began in the past and span to a date in the future

Tested this on Chrome macbook. Added two events as an organizer that span a range of dates that start in the past and end in the future.

SavetomyEYPD button appears and when clicked on expected message appears "This event has happened in the past, are you sure you want to add to your events?"

[paulagaube]

@kathreenriel I have a couple questions about this issue that I have come across while validating. Can we discuss after lunch? I need a break.

[kathreenriel]

Sure I'm on Skype let's chat when your ready