BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

[70.3] Customizer section for hero and PB callout #113

Closed alex-418 closed 5 years ago

alex-418 commented 5 years ago

Create a section in the customizer for this page, to allow setting the pages which have the featured image and excerpt for:

1.) The hero image 2.) "Creating open textbooks with PressBooks" page

ehbeattie commented 5 years ago

Is there a page to view for this one?

alex-418 commented 5 years ago

https://helga.bccampus.ca/wp/opentextbooks/create-open-textbooks/

You can switch out the default page in these sections in the customizers "Create Open Textbooks" section.

ehbeattie commented 5 years ago

Oh, hey, cool. I've added some copy and images to play around. I notice that the title appears twice here, which is odd: https://helga.bccampus.ca/wp/opentextbooks/create-open-textbook

alex-418 commented 5 years ago

@ehbeattie The duplicate title is because that's the page title of the one set in the customizer... as per design in https://github.com/BCcampus/open-sage/issues/70 it shows the title of the page, and then the title of that hero section. Assigning a different page will change that second title.... I've implemented the blue background styling via https://github.com/BCcampus/open-sage/commit/0770b1ef200746f72f8000d66e7b7edcc1288360 to make that more obvious. (please note, clearing browser cache may be required)

blue_bg

alex-418 commented 5 years ago

I've captured the height difference issue between the two in https://github.com/BCcampus/open-sage/issues/120

ehbeattie commented 5 years ago

The title of the hero section should be 'Getting started" but I'm unsure where to change that. Maybe I should wait until my coffee has set in...

Change from this: Screen Shot 2019-03-13 at 6 31 02 AM

To this: Screen Shot 2019-03-13 at 6 31 55 AM

bdolor commented 5 years ago

above Alex notes:

Assigning a different page will change that second title

you would perform that action in the customizer

ehbeattie commented 5 years ago

The page assigned it correct, but changing the page title didn't change the hero header title. #usererror

bdolor commented 5 years ago

Here's a screen shot:

image