search

BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

[70.5] Hero section max-height and styling #120

Closed alex-418 closed 5 years ago

alex-418 commented 5 years ago

Hero section expands based on the excerpt length, making the left side a lot longer than the right, cuasing this issue(see screenshot). Consider giving it a max height and trim the excerpt length.

hero

alex-418 commented 5 years ago

issue also affects cards, fixing those as well (see screenshot)

cards
alex-418 commented 5 years ago

Hero image will always be a fixed height, limit excerpt text and cards to match that height

alex-418 commented 5 years ago

Completed via https://github.com/BCcampus/open-sage/pull/131

This fixes the height issues with the hero image on the homepage, and hero/triple cards in "use open textbooks page". Also applies to the hero image in "create open textbooks page". This trims the excerpt lengths to 40 words (this is closest match to design possible, without having to do this individually for each hero section and card)

alex-418 commented 5 years ago

@ehbeattie Please note that Github automatically closes an issue if it detects some keywords such as "completed" in the text... it's handy, but can be confusing as it's not validated yet. We can re-open these in the case where there's more work.

ehbeattie commented 5 years ago

How shall I proceed?

alex-418 commented 5 years ago

If you're happy with the 40 word count and how the hero and card sections look in the 3 pages I noted above, then please move to validate.

ehbeattie commented 5 years ago

How many characters are allowed on BCcampus? I would like to match what we have implemented there.

alex-418 commented 5 years ago

The design differs slightly, for example there's no excerpt in the BCcampus hero images, but for the others cards yes it's the same excerpt length.

ehbeattie commented 5 years ago

Ok, sounds good.