BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Entire site A11Y: Redundant links, plus lack of descriptive link text in "Learn More" links #143

Closed josieg closed 5 years ago

josieg commented 5 years ago

Describe the bug Throughout the site, many pages have multiple "Learn More" button links. These links need descriptive link text (or unique aria labels). I also have doubts about linking to both the headings AND the "learn more" buttons, because that seems redundant.

To Reproduce Learn More links on the following pages:

Expected behavior I would expect that a page would only have one link to the same place and that links are descriptive.

I would propose removing links from the headings/images and adding descriptive aria-labels to all of the "Learn More" buttons so they are unique. For example, they could match the heading (i.e. FIND OPEN TEXTBOOKS) or be longer (i.e. LEARN HOW TO CREATE AN OPEN TEXTBOOK).

homepage

alex-418 commented 5 years ago

@josieg We discussed this with @ehbeattie and decided to keep the link text as "learn more" but update what the screen reader text would say to include what the heading says.

alex-418 commented 5 years ago

Updated these pages via https://github.com/BCcampus/open-sage/commit/de30e3388055240c88375f082592f4303653cbc8, plus on advocate for open education, and projects/grants page to include the following aria-label on the "learn more" buttons:

aria-label="Read more about (title of the page is here)"

ehbeattie commented 5 years ago

Perfect.