search

BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Homepage A11Y: Stats section screen reader compatability #144

Closed josieg closed 5 years ago

josieg commented 5 years ago

Describe the bug The stats section is confusing for someone using a screen reader, and there are a few reasons for this and I'm not sure about what a good fix would be. Here are the problems I found:

To Reproduce Steps to reproduce the behavior:

  1. Go to https://helga.bccampus.ca/wp/opentextbooks/
  2. Read page with a screen reader.
  3. When reading headings, screen reader says, "Open Education at BCcampus heading 4, 32 heading 3, 149 heading 3, 14604 heading 3, $1459800-$1851366 heading 3, Getting Started heading 4"
  4. When reading links/image descriptions, screen reader says "linked image icon representing an institution"

Expected behavior

My suggestion: Remove alt tags and links from icons, and remove heading status from numbers. Instead create one link (imitating the Browse All Guides and Toolkits button) that says "Find More Open Textbook Stats." Tagging @ehbeattie for approval re: style and any further thoughts.

Screenshots stats

alex-418 commented 5 years ago
  1. I can remove headings from numbers, no problemo
  2. Talked about this one with @ehbeattie and decided to keep the links
  3. I can remove headings from numbers, no problemo
  4. @josieg can you please let us know what you expect these to say instead ?
josieg commented 5 years ago

To confirm, you are going to keep the links on the icons? If that's the case, the alt tag for those icons becomes the link text. Change alt text as follows:

alex-418 commented 5 years ago

Yes. Great, thanks @josieg will change the alt text

alex-418 commented 5 years ago

Completed via https://github.com/BCcampus/open-sage/commit/1678ffd710b06b25791f7dfab30beed34fb05817

ehbeattie commented 5 years ago

Looks great!