Move all menus to the left

BCcampus / open-sage

Theme for open.bccampus.ca

MIT License

1 stars 0 forks source link

Move all menus to the left #162

Closed alex-418 closed 5 years ago

alex-418 commented 5 years ago

Decision captured in https://github.com/BCcampus/open-sage/issues/158 to improve accessibility, the tabbing order for keyboard navigation requires the menu element to come before the content.

alex-418 commented 5 years ago

@ehbeattie Moved the following pages menus to the left via https://github.com/BCcampus/open-sage/commit/4a8148a9544c08896c645900e5ef9e386d594d6a let me know if I missed one!

Find/Browse open textbooks page
Individual book page
Generic (Default) page
Stats page

ehbeattie commented 5 years ago

I've noticed that the child pages in the side nav looks a little odd Screen Shot 2019-03-27 at 1 20 41 PM

alex-418 commented 5 years ago

It looks a little odd because those are grandchildren. The menu itself consists of the child pages. The design didn't have any grandchildren, so that's why styling and functionality are a bit wonky. Can you please confirm the nesting order is correct? And if it is, maybe there's now a need for grandchildren to be on the menu as well? I'll see what I can do about styling, then we'll look at if the functionality works well (right now visiting the grandchild page lists other grandchildren of the parent)

alex-418 commented 5 years ago

Discussed and the content will be restructured so the relationships are Parent and Child only.