search

BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Heading design for new left menu pages #163

Closed alex-418 closed 5 years ago

alex-418 commented 5 years ago

Having moved all menus to the left in #162, we are now left with the following design for each of the following pages (see screenshots below). Issues to fix:

  1. The page titles are in the wrong position, wrong, or duplicated in some pages

  2. Position of the content needs line up/match new sidebar position

Browse/Find open textbooks page:

browse

Single book page:

single

Generic (default) page:

generic

Stats Page:

Didn't need a sidebar but had one, removed it and made it full width via https://github.com/BCcampus/open-sage/commit/30b29117ba7d8f812232c3982a3b2b715e58301d

stats

alex-418 commented 5 years ago

@ehbeattie any additional comments or input for these pages? I will do my best to make them look good and fix the 2 issues I identified. Will let you know when ready for review.

alex-418 commented 5 years ago

@ehbeattie Improvements for Browse/Find open textbooks page finished... how's this look? Any other changes you want to this page? (I haven't pushed to helga, tackling all of these together via #164 then pushing over)

new_browse

alex-418 commented 5 years ago

@ehbeattie Here's the single page ... fixed the duplicated and wrong title:

single

Same thing for generic/default pages: generic

alex-418 commented 5 years ago

Merged via #164 these changes should be on helga for you to review soon. Created #165 a new issue for the wrong breadcrumbs on single book pages.

ehbeattie commented 5 years ago

Great work, Alex. It looks good.

alex-418 commented 5 years ago

The generic landing page templates needs the double page title removed, and the same padding/margins as the others.

alex-418 commented 5 years ago

Completed via https://github.com/BCcampus/open-sage/commit/0afa9c00c82a4897deeed6906f15bbf1442e5aeb the following page has the same treatment applied as others (no double page title, same spacing): https://helga.bccampus.ca/wp/opentextbooks/need-help/

ehbeattie commented 5 years ago

Is it possible to align the two headers more?

Screen Shot 2019-03-27 at 1 15 39 PM
alex-418 commented 5 years ago

The content is indented slightly.... just note that changing that would impact the other pages as well.

ehbeattie commented 5 years ago

Would that mess things up?

alex-418 commented 5 years ago

Not at all... completed via 86a8dcd

ehbeattie commented 5 years ago

Awesome!