search

BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Individual book page A11Y: File icons in collection include full attribution information in the alt tag #172

Closed josieg closed 5 years ago

josieg commented 5 years ago

Describe the bug All download file icons in the collection include full attribution information in the icon's alt tag.

For example, the alt tag for MOBI files is: MOBI file. This icon is licensed under a Creative Commons Attribution 3.0 License. Copyright Yusuke Kamiyamane."

This is confusing for screen-reader users and an incorrect place for icon attributions.

To Reproduce Steps to reproduce the behavior:

  1. Go to Health Case Studies.
  2. Activate screen reader. (Or inspect element to view the alt tag)
  3. Hear the screen reader read out full attribution info for each file download icon it finds.

Expected behavior I expect that the alt tag would not include attribution or copyright information. We may need to find somewhere else for it.

alex-418 commented 5 years ago

Spoke with @ehbeattie and we will remove this from alt tags

alex-418 commented 5 years ago

Completed via https://github.com/BCcampus/opentextbooks/commit/d78cea7bef416df6696233192dc5c6a1a4c48adf