BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Find Open Textbooks: MARC records and other collection 2-column cards #184

Closed josieg closed 5 years ago

josieg commented 5 years ago

Describe the bug According to #16 , it was agreed to use two-column cards on the Find Open Textbooks page to link to the Marc Records and Other Collections pages. I figured out how to set the column cards to the right pages in the customizer, but I could not figure out how to add the excerpt text to the column cards, set the featured images, or remove the hardcoded text above the column cards.

I think part of this issue is a non-dev task and part is a dev task. Will let Erin and Alex determine. marc

alex-418 commented 5 years ago

@josieg Here's a screenshot of the customizer section that controls these. You can add an excerpt and featured image to these pages:

OER

As for the static text, if I recall this wasn't going to change often, so we left it static. @ehbeattie please confirm?

josieg commented 5 years ago

Hi Alex, I think the switch to column cards means that the above text is no longer needed. Erin can confirm though.

And I found both of those pages. I see where to set a featured image, but I still don't see how to set the excerpt. Will let Erin handle it.

alex-418 commented 5 years ago

@josieg oh, try seeing if it's enabled in your screen options (top right corner when editing that page).

josieg commented 5 years ago

Ahha! Thanks, fixed my problem!

josieg commented 5 years ago

I've updated the excerpts. @ehbeattie , can you confirm that it's okay to delete the duplicated text that precedes the column cards and update the featured images so they aren't the same?

ehbeattie commented 5 years ago

I'm not sure I 100% follow. Can you show me what you mean?

josieg commented 5 years ago

Now that the column cards have excerpts, the text preceding them is redundant and can be removed. redundant

ehbeattie commented 5 years ago

Ah, yes. I agree. Please feel free to delete.

alex-418 commented 5 years ago

Removed via https://github.com/BCcampus/open-sage/commit/880dc2173ffb3e7fef07eb525ee4b2c8e0b1c134