search

BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

Math books sorting incorrectly in collection #223

Open josieg opened 4 years ago

josieg commented 4 years ago

Describe the bug When I open the Adult Basic Education > Math category, there are a whole bunch of books listed that shouldn't be appearing there.

I checked a few of the books that are displaying incorrectly here (such as Brief Calculus and Business Math: A Step-by-Step Handbook, and all of those books have the correct categories selected in SOLR.)

To Reproduce Steps to reproduce the behaviour:

  1. Go to the Open Textbook Collection.
  2. In the left subjects menu, click "Adult Basic Education" and then "Math"
  3. The collection will display 101 results (there should be less than 5)
josieg commented 4 years ago

Same thing also seems to be happening to the Business > Entrepreneurship category

alex-418 commented 4 years ago

Summary of investigation and conversation so far with @josieg:

Next steps: Figure out what is unique about the 101 results that appear in the ABE "Math" category, and if there's a bug with the logic generating the menu.

josieg commented 4 years ago

I just noticed that if you just type in "Math" into the collection search, you get the same 101 books.

alex-418 commented 4 years ago

Hi Josie, this appears to be resolved. Can you please confirm?

josieg commented 4 years ago

Yep, can confirm...

josieg commented 4 years ago

Hi Alex, this is happening again but with different categories.

See Social Sciences > Sociology (https://open.bccampus.ca/browse-our-collection/find-open-textbooks/?subject=Sociology)

Also, there is a Physics subcategory showing under Education?

alex-418 commented 4 years ago

@josieg Very interesting, I will look into this further. Can you think of anything that has changed recently. For example, any new characters or changes we made to categories? I will try to confirm if we're getting duplicates back from Equella, or if it's how we're parsing the data that's causing the issue.

josieg commented 4 years ago

FYI the Sociology category is displaying the correct books again. But Physics is still showing up under "Education."

These are all of the changes we've requested be made to the collection categories in 2020.

They include adding the following new sub categories:

And we also put in a request to change the "Creative Non-Fiction" sub-category to "Creative Writing"

alex-418 commented 4 years ago

Thanks @josieg I've resolved the Physics menu item showing up in the incorrect category. Glad to hear the Sociology category is displaying the correct books again. I'm not entirely sure why this happened.

dshaykewich commented 4 years ago

Krista noticed the same error with ABE->Math. Captured here: https://jira.bccampus.ca/browse/BOIS-52

dshaykewich commented 4 years ago

@josieg , how many results should come back in the Chemistry category? I'm currently seeing 61. https://open.bccampus.ca/browse-our-collection/find-open-textbooks/?subject=Chemistry

josieg commented 4 years ago

It's showing me 7 now, which should be correct.