BCcampus / open-sage

Theme for open.bccampus.ca
MIT License
1 stars 0 forks source link

[68.2] Improve WCAG 2.0 rating of website to meet AA standards #89

Closed alex-418 closed 5 years ago

alex-418 commented 5 years ago

Investigate changes as discovered in #88 to meet AA standards

alex-418 commented 5 years ago

Fix the following on all pages:

  1. Header nesting - header following h1/h2 are incorrect.
  2. Add text to the label elements
  3. select elements missing an associated label.
alex-418 commented 5 years ago
  1. Header nesting on homepage fixed via https://github.com/BCcampus/open-sage/commit/1aab90948d9fda1664945ccdcc1c9b1c6c0a1dce

  2. Adding text to labels on homepage: This one required replacing wp_get_search_form() in the header with our own custom search form so that we can generate the search form with the aria-label attribute to make it screen-reader friendly.

  3. In the find open textbooks page, the select list for the filters needed a label. I opted to use aria-label attribute once again via https://github.com/BCcampus/opentextbooks/commit/3ef4387008a0ebdf506a6018797169db07d7aed2

This tackles all of the major accessibility issues that I found using the following tool: https://achecker.ca/checker/index.php

*Please note, it will still give a warning forlabel element, this is because it does not detect the aria-label attribute which also satisfies this requirement, but it does so without needing to have visible text for non-screen reader users on the page. This matches our design better.

ehbeattie commented 5 years ago

Ok...

josieg commented 5 years ago

I have some comments on this actually. I went through the page with a screen reader and noticed some things that could use improvement. This is just for the home page. Happy to talk about any of this more if there are questions.

alex-418 commented 5 years ago

Nice, thanks @josieg for taking the time to go through it with a screen reader. I have never used one but would be keen to learn, it'd be great to make this work well for screen readers. My suggestion would be to put each of these (along with any other ones you discover) into the issue backlog at https://github.com/BCcampus/open-sage so we can discuss, prioritize, estimate, and schedule into the next sprint.

josieg commented 5 years ago

Awesome. I will move these into their own issues and add more if I find any. If you use a windows computer, I can give you some tips on using screen readers. I have no experience with Macs.