search

BCcampus / pressbooks-mpdf

[UNMAINTAINED] open source HTML to PDF conversion
GNU General Public License v2.0
7 stars 7 forks source link

Fix #20 #21

Closed greatislander closed 7 years ago

greatislander commented 7 years ago

This should clear up the issue identified by @crism in #20. Two things that I am pretty sure should be true:

  1. There is no need to require any files if vanilla/htmlawed is being used, as in that case it will have been autoloaded with Pressbooks Core.
  2. We should be able to handle backwards compatibility with function_exists(). But this may not even be necessary, as I don't think this version of Pressbooks mPDF will work with Pressbooks < 3.9.8.
greatislander commented 7 years ago

Actually: you shouldn't even need to do the backwards-compatibility check, because the mPDF export module was in Pressbooks core prior to 3.9.8. Sorry for the confusion.