search

BCcampus / pressbooks-mpdf

[UNMAINTAINED] open source HTML to PDF conversion
GNU General Public License v2.0
7 stars 7 forks source link

update configuration options #33

Closed bdolor closed 6 years ago

bdolor commented 6 years ago

Description

mpdf > v7.0 has different configuration options than mpdf < 7.0. Ref https://mpdf.github.io/configuration/configuration-v7-x.html

Expected behaviour

User defined options from global configurations and mpdf configurations passed to the Mpdf class need to be reflected in the output.

Actual behaviour

Since these options are handled differently in the latest version, and there may be more configuration options available in 7.0+ these options will need to be handled differently as they're passed onto the Mpdf class.

depends on https://github.com/BCcampus/pressbooks-mpdf/issues/30

bdolor commented 6 years ago

@lucwrite - also ready for validation. Global Options and Mpdf Options are where this can be validated.

bdolor commented 6 years ago

Known Issues: Two Level Table of Contents (Global Options) won't work, because Mpdf has its own mechanism.

Still outstanding Mpdf options (will continue to pick away at these): image

bdolor commented 6 years ago

resolved via https://github.com/BCcampus/pressbooks-mpdf/commit/58ce03d3ea29064cb7e4a4b9acc94042499e43df