search

BCcampus / pressbooks-mpdf

[UNMAINTAINED] open source HTML to PDF conversion
GNU General Public License v2.0
7 stars 7 forks source link

Not exporting all chapters in Table of Contents #51

Closed beckej13820 closed 6 years ago

beckej13820 commented 6 years ago

Description

When exporting PDFs, Table of contents is coming in incomplete. Some but not all chapters are not being displayed.

screen shot 2018-02-26 at 7 44 03 pm

Expected behaviour

I would expect all the chapter titles in the table of contents. screen shot 2018-02-26 at 7 45 12 pm

Actual behaviour

I can't make out a pattern in the behavior. Some books have no chapter titles at all, some books have some but not all.

screen shot 2018-02-27 at 8 09 57 am

Steps to reproduce the problem

I network disabled all plugins except Pressbooks, Pressbooks Aldine, Pressbooks McLuhan, Pressbooks-MPDF

Export a book to PDF and PDF only.

System Information

bdolor commented 6 years ago

thank you @beckej13820 - I will look into this.

colomet commented 6 years ago

also the TOC of the pdf is not complete, do not have the names

captura de pantalla 2018-03-02 a las 22 19 44

colomet commented 6 years ago

13 is the part, and the name is correct, but 14, 15 and 16 have just the chapter number, not the name.

Also, maybe the chapters and parts must follow different numeration. We can not have 100 chapters and 10 parts and the page number 110. looks complicate maybe.

also Pressbooks do not count the parts for the numbered of the chapters. Look, the part are roman numbers and the chapters are arabic numbers

captura de pantalla 2018-03-02 a las 22 29 09

bdolor commented 6 years ago

resolved via https://github.com/BCcampus/pressbooks-mpdf/pull/54