search

BCcampus / pressbooks-mpdf

[UNMAINTAINED] open source HTML to PDF conversion
GNU General Public License v2.0
7 stars 7 forks source link

Sidebar textboxes don't appear as sidebars #67

Open josieg opened 5 years ago

josieg commented 5 years ago

Description

Sidebar textboxes appear as regular textboxes in mPDF.

Expected behaviour

When I have a sidebar in my book, I expect that it will appear as a sidebar in mPDF format.

What the sidebar textbox looks like in Prince: princesidebar

Actual behaviour

Textboxes that are added as sidebars appear as regular textboxes in mPDF.

What the sidebar textbox looks like in mPDF: mpdfsidebar

Steps to reproduce the problem

  1. Add a sidebar textbox to your chapter.
  2. Export book as mPDF.
  3. Look at the textbox that is supposed to be a sidebar. See that it is not a sidebar and just a regular textbox. Sigh in defeat.
bdolor commented 5 years ago

resolved via https://github.com/BCcampus/pressbooks-mpdf/commit/5cd67ff1f83d35678c9344e918adc022efdf025c

josieg commented 5 years ago

Can we make it so text wraps around the textbox and there is some space between the text and the textbox border? mpdfsidebar2.JPG

bdolor commented 5 years ago

would like to leave a note here that this change has been reverted via https://github.com/BCcampus/pressbooks-mpdf/commit/8429a57c25ea10e7ed25669537da06e263e167b2 . The level of CSS support makes this otherwise very simple request more challenging.

https://mpdf.github.io/css-stylesheets/supported-css.html