BCcampus / pressbooks-textbook

A plugin that extends Pressbooks for textbook authoring
GNU General Public License v2.0
25 stars 13 forks source link

Textboxes not rendering Global options colours #175

Closed pbstudent closed 6 years ago

pbstudent commented 6 years ago

Description

Textboxes not rendering Global options colours

Expected behaviour

display correct colours

Actual behaviour

no colours

Steps to reproduce the problem

created a test page with text boxes.

System Information

bdolor commented 6 years ago

@pbstudent - more detail in steps to reproduce the problem will be helpful for next time.

create a test page with text boxes

Things work as expected for me. Is this happening in the wysiwg/dashboard or when viewing the book as a reader? Limited to web view or are you seeing this in exports? By global options colours, do you mean to go into 'theme options' change the value of 'Header Color' to a non-default colour? Is this behaviour happening on textboxes that were created previously or newly (after 4.1.2 update) created textboxes? Finally, does deactivating/reactivating the theme work to resolve this issue?

pbstudent commented 6 years ago

deactivating/reactivating the theme did not work "behaviour happening on textboxes that were created previously or newly (after 4.1.2 update)...?"

Sample of default Appearance > theme options > global options screenshot_2018-07-13 theme options mem pressbooks

Sample of editor view screenshot_2018-07-13 edit chapter mem pressbooks

Sample of web view screenshot_2018-07-14 test page private mem

bdolor commented 6 years ago

@pbstudent would you confirm that you have the latest version of the parent theme McLuhan installed? https://github.com/pressbooks/pressbooks-book/releases

pbstudent commented 6 years ago

McLuhan 2.3 now updated to 2.4 Editor view has not changed changed. However Web view has now changed to: screenshot_2018-07-14 test page mem

bdolor commented 6 years ago

The textboxes are rendering as expected for me in both the dashboard and web view. Sometimes browser cache can play a role. Saving theme options or re-activating the theme can also trigger/force a rebuild.

pbstudent commented 6 years ago

Thanks that worked: Activating another theme then reactivating Open Textbook theme for each book site resolved the editor view. Fortunately not hundreds of book sites.

pbstudent commented 6 years ago

Also resaving the Theme Options > Global Options reset the colours.