search

BCcampus / pressbooks-textbook

A plugin that extends Pressbooks for textbook authoring
GNU General Public License v2.0
25 stars 13 forks source link

Increase font size option not enlarging text in standard/shaded textboxes and table cells in the Open Textbooks theme #183

Closed josieg closed 5 years ago

josieg commented 5 years ago

Description

Here is where I have been testing: https://pressbooks.bccampus.ca/abookfortestingprod/chapter/chapter-1/

Text inside standard and shaded textboxes (including the side-bar equivalents of these textboxes) does not increase in size when the "Increase font size" option is clicked in the Pressbooks webbook when the Open Textbooks Theme is enabled. But the various educational textboxes and sidebar textboxes do increase in size as expected.

In addition, text in <th> and <td> cells does not increase in size when you click the Increase Font Size button when the Open Textbooks Theme is enabled.

One thing to note is that if you look at my table in the chapter I was testing in, you will see that there is a line-spacing problem when there are more than one paragraph of text in a single cell. I think this problem is a separate one that's based in the McLuhan theme, and it has been reported to Pressbooks core: https://github.com/pressbooks/pressbooks-book/issues/242

Expected behaviour

When I have the Open Textbook theme enabled and I add text to standard/shaded textboxes and tables, I expect that their text size will increase along with the other text on a page in the webbook when someone clicks the "Increase Font Size" button.

Actual behaviour

When I click the "Increase Font Size" button in a Pressbooks webbook that is using the Open Textbook theme, all text increases in size except for text in table cells and text in shaded and standard textboxes.

Steps to reproduce the problem

  1. Add a standard or shaded textbox to a chapter in Pressbooks.
  2. Add text to that textbox.
  3. Add regular text ourside of the textbox for comparison.
  4. Save the chapter and open the chapter in the webbook.
  5. Click "Increase Font Size."
  6. The text in the shaded/standard textboxes will not increase in size. The text not inside the textbox will increase in size.

System Information

pressbooks.bccampus.ca

josieg commented 5 years ago

Accidentally saved before I finished writing - standby

bdolor commented 5 years ago

resolved via https://github.com/BCcampus/pressbooks-textbook/commit/d4214253c8e957d86aa260b0905c146991aa803b

bdolor commented 5 years ago

captions resolved via https://github.com/BCcampus/pressbooks-textbook/commit/77068c7cbfa33fc92b86b2c757e3ee4793b6a253

josieg commented 5 years ago

Everything here looks good.