search

BCcampus / pressbooks

Pressbooks – the CMS for books
https://pressbooks.org/
GNU General Public License v3.0
0 stars 0 forks source link

Dismissible Admin notice on OSI #12

Closed alex-418 closed 6 years ago

alex-418 commented 6 years ago

https://github.com/BCcampus/pressbooks-openstax-import/issues/65

alex-418 commented 6 years ago

Tracked down the bug, the JS file wasn't being loaded, fixed that via https://github.com/BCcampus/pressbooks-openstax-import/commit/6a677c83db0b0bb7cd2ea943d5bc1fd1c64cbef1, but now now the url of file is wrong, this is bedrock related (brad tested on non-trellis PB to confirm). Since we don't own the JS file, fix is tricky. One possible solution is moving the JS file and PAnD class into the OSI plugin, and loading it from there, instead of requiring form composer.