search

BD2KGenomics / brca-website-deprecated

This repo is deprecated! Please use https://github.com/BD2KGenomics/brca-exchange
Apache License 2.0
6 stars 9 forks source link

Expert Reviewed changes #121

Closed strbean closed 8 years ago

strbean commented 8 years ago

Implement the changes specified here: https://docs.google.com/presentation/d/1VuWmLXl39fJYqlYn0mStoPkUDeKzIcYhO8kZOcG1wXM/edit

and additional notes here: https://docs.google.com/document/d/1-9SBeLRVnPiKgntt6bByAH7J75lM7J0ha7ESe2UmqAk/edit

Also, #108

maryjgoldman commented 8 years ago

Great! Where can I view these changes? I believe we need to set up a beta testing place, correct?

strbean commented 8 years ago

It's live on http://brcaexchange.cloudapp.net

maryjgoldman commented 8 years ago

Looks really good!! Just a few comments/changes:

maryjgoldman commented 8 years ago

Also, can all the links open in new tabs? Sorry I didn't indicate that on the wireframes!

strbean commented 8 years ago

With regards to Supporting Evidence URL: just to double check, this corresponds to the URL_ENIGMA column in the table, correct?

For the Protein Abbrev, getting a different heading between the search results and the variant display has proven difficult, I'll work on it.

On Wed, Jul 20, 2016 at 4:05 PM, maryjgoldman notifications@github.com wrote:

Looks really good!! Just a few comments/changes:

  • The labels for the variant table are aligned a bit wonky. I know Brian (Craft) had trouble with these too. Is there a way to make them all appear left or center aligned (whatever is easiest)? Also, can we make the clinical significance column wider so that each variant takes up no more than 2 lines?
  • Contrary to what will be displayed in the 'All Data' pages, the Supporting Evidence URL(s) in this case is always ONLY a link to the http://hci-exlovd.hci.utah.edu/variants.php page. In the 'All Data' pages this will include links to pubmed, etc, that you have done here, but on the 'Expert Reviewed' pages it's only to the HCI page.
  • Date Last Evaluated: 10 August 15 ---> 10 August 2015
  • Label of 'Protein Abbrev' in details page --> 'Abbreviated AA Change'

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BD2KGenomics/brca-website/pull/121#issuecomment-234110822, or mute the thread https://github.com/notifications/unsubscribe-auth/AFULxgNmmNlFXOC6SZFRXWhRH6LSoOJGks5qXqm_gaJpZM4JRQbF .

maryjgoldman commented 8 years ago

I'll let @melissacline comment about the URL since I don't have access to the table. An initial look says no? It doesn't look like it is filled in for many variants.

Yes, I suspected as much about the different heading. If it ends up being too difficult we can push back and ask them if it's ok to leave as is.

melissacline commented 8 years ago

Yes, the Supporting Evidence link should be from the URL_ENIGMA field. That was the data they wanted.

For the differences in heading between the variant table and the variant details page, we can definitely push back if it proves difficult (as it already has, from the sound of things). As you'll hear on the call tomorrow, our users are scientists who aren't necessarily computational, and while they might have their vision of the functionality they want, they rely on us to clarify what's easy and what's hard.

On Wed, Jul 20, 2016 at 4:23 PM, maryjgoldman notifications@github.com wrote:

I'll let @melissacline https://github.com/melissacline comment about the URL since I don't have access to the table. An initial look says no? It doesn't look like it is filled in for many variants.

Yes, I suspected as much about the different heading. If it ends up being too difficult we can push back and ask them if it's ok to leave as is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BD2KGenomics/brca-website/pull/121#issuecomment-234113969, or mute the thread https://github.com/notifications/unsubscribe-auth/ABoqhzyPWERx2HGM3Fan5vX-e2x7xfo_ks5qXq4AgaJpZM4JRQbF .

maryjgoldman commented 8 years ago

More feedback:

strbean commented 8 years ago

I was (nearly) able to fix the issues with the table heading. I've attached screenshots of the new behavior. The only remaining problem is the sorting buttons will just barely clip with the text at certain screen sizes. Unfortunately trying to pad the text to stop this leads to extremely wonky alignment once the columns get squeezed down enough that they take up two rows.

Edit: Whoops, replied in email and I didn't it was a github notification!

https://cloud.githubusercontent.com/assets/5573574/17032936/8afebb80-4f30-11e6-96e0-e69d206ecfaf.png https://cloud.githubusercontent.com/assets/5573574/17032934/8ae68cb8-4f30-11e6-9fd6-7bf0ef40240c.png https://cloud.githubusercontent.com/assets/5573574/17032935/8afb8dfc-4f30-11e6-8674-a901f38add23.png

On Thu, Jul 21, 2016 at 9:40 AM, maryjgoldman notifications@github.com wrote:

More feedback:

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BD2KGenomics/brca-website/pull/121#issuecomment-234311485, or mute the thread https://github.com/notifications/unsubscribe-auth/AFULxh08YhhRmkfWzH_UmK-yuFqfQqvrks5qX6DogaJpZM4JRQbF .