search

BD2KGenomics / brca-website-deprecated

This repo is deprecated! Please use https://github.com/BD2KGenomics/brca-exchange
Apache License 2.0
6 stars 9 forks source link

Lollipop becomes unusable, slow #122

Closed david4096 closed 8 years ago

david4096 commented 8 years ago

After using the viz on safari for a few seconds it became intractably slow. Switching to the filter tab seemed to still be using resources when I changed filter options. Had to close and reopen the tab. Perhaps consider placing a button to avoid unnecessary reloading of data.

melissacline commented 8 years ago

Mary, would you work with David (Steinberg) to reproduce / characterize this issue?

maryjgoldman commented 8 years ago

@david4096 I'm looking around the filters and lollipop plot on Safari and I think I see at least part of what you're seeing? Source selection is normally quite fast, however if you open up the lollipop plot and then try to use the source selection filter, it is incredibly slow. I see this most pronounced on Safari but it also in Chrome and FF.

Is this what you were talking about or is there something else as well?

david4096 commented 8 years ago

Hi @maryjgoldman, the whole site became unusable in the circumstance you've reproduced. In general, the performance of zooming and panning the lollipop chart on Safari makes it unusable. A quick fix would be to show only known pathogenic and benign variants. A slightly more involved fix would be grouping elements together, and only rendering elements that are visible. The variants at high density get a different SVG element though they are all drawing to the same pixels.

maryjgoldman commented 8 years ago

@david4096 I am not able to reproduce what you're saying. I just zoomed and panned on the lollipop chart in Safari for several minutes and didn't notice any slow down. It's maybe a bit jerky (from the beginning) but it still is quite usable.

david4096 commented 8 years ago

@maryjgoldman thanks ;). My specific pain points are that the intermediate zoom levels aren't helpful and seem to slow things down. I found the scroll wheel behavior frustrating because it would hijack when I scrolled down. I think more than a few thousand SVG elements will always cause a browser to choke.

But yes, this issue can close without messing with the chart!

maryjgoldman commented 8 years ago

Ok, I think understand now! I think I'd like to create two issues:

  1. If you have the lollipop plot up and use the source filter, the filter is incredibly slow. This is a bug that needs to be fixed.
  2. I agree that the scrolling to zoom can be frustrating when you are trying to scroll down the page, especially since you can double click to zoom in anyways. I will file a feature request to remove the scroll to zoom.

I'm going to close this and create these two new ones.

Also, can we all agree to call it a 'lolliplot'? Because that's what I keep on typing by accident.