Addressing feedback from Mary

strbean commented 8 years ago

Fix table headers
Remove NM... and NP... from HGVS Nucleotide and HGVS Protein
dates: 1 January 15 -> 1 January 2015
Use URL_ENIGMA for Supporting Evidence URL
Open all offsite links in new tab (PubMed, Enigma Rules, Supporting Evidence)
On variant detail page: Protein Abbrev -> Abbreviated AA Change

strbean commented 8 years ago

Live on http://brcaexchange.cloudapp.net/

maryjgoldman commented 8 years ago

This looks great. My only comment is that none of the variants seem to have supporting URLs. @melissacline can you comment on this?

strbean commented 8 years ago

Woops, looks like I botched the switch to using URL_ENIGMA. Fixing now.

On Thu, Jul 21, 2016 at 2:24 PM, maryjgoldman notifications@github.com wrote:

This looks great. My only comment is that none of the variants seem to have supporting URLs. @melissacline https://github.com/melissacline can you comment on this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/BD2KGenomics/brca-website/pull/123#issuecomment-234388760, or mute the thread https://github.com/notifications/unsubscribe-auth/AFULxv0yoFuklFL0M68EvKyFcBEpXF8hks5qX-OhgaJpZM4JSGUw .

BD2KGenomics / brca-website-deprecated

Addressing feedback from Mary #123