search

BD2KGenomics / brca-website-deprecated

This repo is deprecated! Please use https://github.com/BD2KGenomics/brca-exchange
Apache License 2.0
6 stars 9 forks source link

Remove scroll to zoom on lolliplot? #130

Closed maryjgoldman closed 7 years ago

maryjgoldman commented 8 years ago

Scrolling to zoom can be frustrating when you are trying to scroll down the page, especially since you can double click to zoom in anyways.

strbean commented 8 years ago

Funny, I was running into this issue when investigating the performance issues! Frustrating indeed.

strbean commented 8 years ago

Looks like this is going to harder than it should be. The D3 drawing library, which the lolliplot uses, didn't add the option of ignoring certain event types until a much later version.

melissacline commented 7 years ago

@maryjgoldman if this is going to be hard to fix, how important do you think it is?

cmarkello commented 7 years ago

@strbean, are you looking at the lollipop github repo? It might be easier to have more powerful control over the tool if you can edit the source? This particular version of lollipop can be found here.

maryjgoldman commented 7 years ago

I don't think it's that important to fix. It's annoying but users can work around this. Also, it's not an often used feature at this point. We can revisit if we get feedback from users.

cmarkello commented 7 years ago

Yeah when I was developing this, I ran into this issue months ago, but couldn't find the right tools to solve it. Basically my temporary work-around was to embed the interactive plot within a button that's default-closed and relying on user discretion in using the tool. It performs universally well after filtering the data when there are few elements rendered. Basically it's dependent on the clients hardware as far as rendering and performance is concerned which is not ideal and should be binned based on zoom level.