search

BD2KGenomics / dcc-action-service

A place for our business logic written in Luigi that triggers workflow launches.
Apache License 2.0
1 stars 3 forks source link

Add instance flavour option #21

Closed alex-hancock closed 7 years ago

alex-hancock commented 7 years ago

Added Luigi parameter 'vm_instance_type' to accept variable instance, defaults to c4.8xlarge. Successfully integrated using current decider run script.

wshands commented 7 years ago

Alex please add the instance type to the call to RNA-Seq.py in run_Luigi_Deciders.sh; other than that the pull request looks OK; but what about the question in the install_boostrap script that asks for a 'flavour' instance type? Would that be the default?

alex-hancock commented 7 years ago

Above commit adds instance type option in run_Luigi_Deciders.sh

alex-hancock commented 7 years ago

The default is written in the RNA-Seq.py Luigi parameter, I set the default to c4.8xlarge. The install_boostrap script writes that information to the youxia script, but i will confirm this. I will also test running this with a different instance type.