search

BD2KGenomics / toil-scripts

Toil workflows for common genomic pipelines
Apache License 2.0
33 stars 18 forks source link

Backport mate-pair heuristic and add disk req (resolves #454, resolves #455) #457

Closed jvivian closed 8 years ago

jvivian commented 8 years ago

resolves #454, resolves #455

jvivian commented 8 years ago

@hannes-ucsc — Ready for review. "Mate pair heuristic" is a direct cherrypick from the branch that was merged into master.

hannes-ucsc commented 8 years ago

I think you're missing 76d1db418116c5e203f23612baecc52a09bffa48 and maybe 8762fcd4654eb660a50374d47f27895e20fc2eff. You may want to make it a habit to squash the review edits into the original commits so this doesn't happen.

Also, 1fb6f4f0e39ce502360847e44da5670184a3c1f6 does not look like a cherry-picked commit. I think we should distinguish between actual CPs (the ones that get merged automatically) and manual back-ports.

hannes-ucsc commented 8 years ago

I think with the new GH review feature, we can do away with the needs work tag.

jvivian commented 8 years ago

Thanks @hannes-ucsc — sloppy work, can't believe i missed that.

jvivian commented 8 years ago

@hannes-ucsc — Ready for review