R6 wrapper classes - Githubissues

olegat commented 3 years ago

This pull request provides an R6 implementation of the Python classes in src/COVID19/*.py

Some basic unit testing was done for these classes.

I've fixed all the notes / warnings / errors from R CMD check except for one error.

There's an error where tests fail on the 32-bit DLL (Windows): it looks like the compiled C code is causing a crash.
The 64-bit DLL is unaffected and works as intended. This might be okay for CRAN submission if we only redistribute 64bit binaries.

There is still some minor polishing up to do, I've labelled these with TODO(olegat) comments.

p-robot commented 3 years ago

Thanks, Oli. This looks great. Does this require a specific version of SWIG?

olegat commented 3 years ago

Yes this requires swig 3.0.12

I've checked with swig 4.0.2 but this version still triggers an error. I've filed a bug with swig for this. https://github.com/swig/swig/issues/1901

BDI-pathogens / OpenABM-Covid19