BDI-pathogens / phyloscanner

Phylogenetics between and within hosts at once, all along the genome.
GNU General Public License v3.0
47 stars 14 forks source link

Please consider providing an official Dockerfile and docker container for this tool #80

Open Masterxilo opened 1 month ago

Masterxilo commented 1 month ago

We are building reproducible pipelines with this tool. An essential part of that is to install fixed versions of all dependencies in a known environment.

Docker solves these problems, and I think it would be useful for this tool to provide and officially maintained shareable Dockerfile that installs all dependencies in known-good versions. I know you provide a VM image, but it's too heavyweight IMO.

A colleague has written a version of such a file Dockerfile_phyloscanner.txt.

I have refined that to freeze the versions of most dependencies, in particular the version of the phyloscanner repository clone: Dockerfile_phyloscanner-fixed-versions.txt

Freezing versions is absolutely essential for integrating this tool into reproducible automated pipelines. Just this past month a breaking change https://github.com/BDI-pathogens/phyloscanner/commit/7c2cba9c5fee1e6dbb4da9792cf8bc34feee63b5 changed an output file name: _patStats became _patStats.csv

Thanks for considering this.